Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo(ticdc): return internal error in redo writer (#11011) #11093

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11011

What problem does this PR solve?

Issue Number: close #10124

What is changed and how it works?

  • return internal error in redo writer

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 14, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 14, 2024
Copy link
Contributor

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@9c38750). Click here to learn what that means.

Additional details and impacted files
Components Coverage Δ
cdc 61.7961% <0.0000%> (?)
dm 51.2851% <0.0000%> (?)
engine 63.4091% <0.0000%> (?)
Flag Coverage Δ
unit 57.4920% <94.7368%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11093   +/-   ##
================================================
  Coverage               ?   57.4920%           
================================================
  Files                  ?        852           
  Lines                  ?     125786           
  Branches               ?          0           
================================================
  Hits                   ?      72317           
  Misses                 ?      48041           
  Partials               ?       5428           

@CharlesCheung96
Copy link
Contributor

/retest

1 similar comment
@CharlesCheung96
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 5090def into pingcap:release-8.1 May 15, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants