Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(redo)ticdc: fix the event orderliness in redo log #11111

Closed

Conversation

hongyunyan
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #11096

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 15, 2024
Copy link
Contributor

ti-chi-bot bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hongyunyan, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.5345%. Comparing base (c1ee219) to head (7fe7657).
Report is 3 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.9759% <100.0000%> (+0.0894%) ⬆️
dm 51.1844% <ø> (-0.0687%) ⬇️
engine 63.4091% <ø> (+0.0282%) ⬆️
Flag Coverage Δ
unit 57.5345% <100.0000%> (+0.0183%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11111        +/-   ##
================================================
+ Coverage   57.5161%   57.5345%   +0.0183%     
================================================
  Files           853        853                
  Lines        125742     125714        -28     
================================================
+ Hits          72322      72329         +7     
+ Misses        48037      48009        -28     
+ Partials       5383       5376         -7     

@hongyunyan hongyunyan closed this May 16, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redo apply panic: "insert events should be emitted after other kinds of events in the same transaction"
2 participants