Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log(ticdc): Add more error query information to the returned error to facilitate users to know the cause of the failure (#10945) #11423

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10945

What problem does this PR solve?

Issue Number: close #11254

What is changed and how it works?

Add more error query information to the returned error to facilitate users to know the cause of the failure.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 29, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 29, 2024
@hongyunyan
Copy link
Collaborator

/retest

1 similar comment
@3AceShowHand
Copy link
Contributor

/retest

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@9e42a50). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.8670% <0.0000%> (?)
dm 51.2970% <0.0000%> (?)
engine 63.4232% <0.0000%> (?)
Flag Coverage Δ
unit 57.5321% <50.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11423   +/-   ##
================================================
  Coverage               ?   57.5321%           
================================================
  Files                  ?        852           
  Lines                  ?     125787           
  Branches               ?          0           
================================================
  Hits                   ?      72368           
  Misses                 ?      48024           
  Partials               ?       5395           

@ti-chi-bot ti-chi-bot bot merged commit 7cdc3a1 into pingcap:release-8.1 Jul 30, 2024
26 of 27 checks passed
@lidezhu lidezhu deleted the cherry-pick-10945-to-release-8.1 branch October 23, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants