ticdc(redo, sink): return correct error in redo writer & fix default retryer (#11747) #11763
+45
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
lgtm
release-note
ti-chi-bot
bot
added
cherry-pick-approved
CharlesCheung96
force-pushed
the
cherry-pick-11747-to-release-7.5
branch
from
16cf806
to
5ba4480
Compare
CharlesCheung96
approved these changes
Nov 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CharlesCheung96
force-pushed
the
cherry-pick-11747-to-release-7.5
branch
from
5ba4480
to
acd6495
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #11747
What problem does this PR solve?
Issue Number: close #11744
What is changed and how it works?
This issue is introduced in #11011. If redo encoding worker closed since
context canceld(ref the fix), the external module is not aware of the internal error anyway. Then the checkpoinTs/resolvedTs may continue to advance normally even if the redo writer has been closed.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note