Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the memory leak in sink manager (#1401) #1402

Merged
merged 3 commits into from
Feb 3, 2021
Merged

fix the memory leak in sink manager (#1401) #1402

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b939a96
fix mem leak
Feb 3, 2021
0303d09
empty commit to trigger github action
amyangfei Feb 3, 2021
7a989c4
Merge branch 'release-4.0' into fix_leak_4.0
amyangfei Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cdc/sink/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ func (t *tableSink) FlushRowChangedEvents(ctx context.Context, resolvedTs uint64
return t.manager.flushBackendSink(ctx)
}
resolvedRows := t.buffer[:i]
t.buffer = t.buffer[i:]
t.buffer = append(make([]*model.RowChangedEvent, 0, len(t.buffer[i:])), t.buffer[i:]...)
overvenus marked this conversation as resolved.
Show resolved Hide resolved

err := t.manager.backendSink.EmitRowChangedEvents(ctx, resolvedRows...)
if err != nil {
Expand Down