Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink: fix avro timezone (#1615) #1712

Merged
merged 5 commits into from
May 26, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 27, 2021

cherry-pick #1615 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In ticdc repo:
git pr https://github.com/pingcap/ticdc/pull/1712

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/ticdc.git pr/1712:release-5.0-1f1e1aaf16e1

What problem does this PR solve?

What is changed and how it works?

  • Restore timezone information in Avro encoder.

Check List

Tests

  • Unit test

  • Integration test
    Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix time zone lost in Avro output.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added bug-from-user Bugs found by users. component/sink Sink component. status/ptal Could you please take a look? size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Apr 27, 2021
@ti-srebot ti-srebot added this to the v5.0.2 milestone Apr 27, 2021
@liuzix
Copy link
Contributor

liuzix commented May 7, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 7, 2021
@zier-one
Copy link
Contributor

zier-one commented May 8, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • leoppro
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 8, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed status/ptal Could you please take a look? labels May 25, 2021
@lonng
Copy link
Contributor

lonng commented May 25, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ed7f417

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2021
@amyangfei
Copy link
Contributor

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@2e9812c). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #1712   +/-   ##
================================================
  Coverage               ?   53.7367%           
================================================
  Files                  ?        153           
  Lines                  ?      16097           
  Branches               ?          0           
================================================
  Hits                   ?       8650           
  Misses                 ?       6534           
  Partials               ?        913           

@amyangfei
Copy link
Contributor

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit fa8979d into pingcap:release-5.0 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-from-user Bugs found by users. cherry-pick-approved Cherry pick PR approved by release team. component/sink Sink component. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants