Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puller/sorter: remove manual GC settings #2214

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Do not change default GC settings, it could reduce the minimum mutator utilization and lead to #2202.

Close #2202

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Capturing 6k tables.

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix gRPC keepalive error when memory pressure is high.

@overvenus overvenus added type/bugfix This PR fixes a bug. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. component/sorter Sorter component. labels Jul 4, 2021
@overvenus overvenus changed the title puller/sorter: remove manual GC setttings puller/sorter: remove manual GC settings Jul 4, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 4, 2021
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trace result from #2202 shows the GC pause time reduces from 25s to 7s after turning off gc percent adjust. However 7s is still quite a long GC pause time. Is there any more PRs to address this problem.

@overvenus
Copy link
Member Author

The trace result from #2202 shows the GC pause time reduces from 25s to 7s after turning off gc percent adjust. However 7s is still quite a long GC pause time. Is there any more PRs to address this problem.

7s pause is likely caused by memory leak with new ower enabled, here is the issue https://github.com/pingcap/ticdc/issues/2212

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2021
@ti-chi-bot
Copy link
Member

@ben1009: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2021
@amyangfei
Copy link
Contributor

This pr will be evaluated by more tests

@amyangfei amyangfei added the needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. label Aug 9, 2021
@overvenus
Copy link
Member Author

I am going to merge this PR. Tests (https://github.com/pingcap/ticdc/pull/2699#issue-724007913) show without changing default GC setting, TiCDC can handle 140G incremental data (no OOM).

@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@overvenus: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@overvenus overvenus added require-LGT1 Indicates that the PR requires an LGTM. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 1, 2021
@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 610833b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2021
@overvenus
Copy link
Member Author

/run-kafka-tests
/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2214 (6c46ceb) into master (81c22b1) will increase coverage by 5.2245%.
The diff coverage is 68.8027%.

@@               Coverage Diff                @@
##             master      #2214        +/-   ##
================================================
+ Coverage   55.8716%   61.0962%   +5.2245%     
================================================
  Files           169        161         -8     
  Lines         20667      17916      -2751     
================================================
- Hits          11547      10946       -601     
+ Misses         8012       5975      -2037     
+ Partials       1108        995       -113     

@ti-chi-bot ti-chi-bot merged commit 7ce871a into pingcap:master Sep 2, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2718.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2719.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2720.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2721.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/sorter Sorter component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unified sorter manual GC may pause all goroutines and cause gRPC keepalive dog timeout
7 participants