Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: fix new owner updating checkpoint too early with pending DDL (#2252) #2290

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2252

What problem does this PR solve?

What is changed and how it works?

  • Changed the start-ts of DDL puller to checkpoint - 1, to satisfy the open-interval assumption by TiKV.
  • Fetch the snapshot of meta data at checkpoint instead of checkpoint-1 avoid overlap between listened DDL events and fetched schema snapshot.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix potential DDL loss when owner crashes while executing DDL

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added component/ddl DDL component. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Jul 14, 2021
@ti-chi-bot ti-chi-bot requested a review from lonng July 14, 2021 07:58
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 14, 2021
@amyangfei amyangfei added this to the v5.1.1 milestone Jul 14, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2021
@liuzix
Copy link
Contributor

liuzix commented Jul 14, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: bddbe00

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.1@cae9441). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.1      #2290   +/-   ##
================================================
  Coverage               ?   56.0014%           
================================================
  Files                  ?        166           
  Lines                  ?      19837           
  Branches               ?          0           
================================================
  Hits                   ?      11109           
  Misses                 ?       7657           
  Partials               ?       1071           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/ddl DDL component. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants