-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner: fix new owner updating checkpoint too early with pending DDL (#2252) #2290
owner: fix new owner updating checkpoint too early with pending DDL (#2252) #2290
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bddbe00
|
Codecov Report
@@ Coverage Diff @@
## release-5.1 #2290 +/- ##
================================================
Coverage ? 56.0014%
================================================
Files ? 166
Lines ? 19837
Branches ? 0
================================================
Hits ? 11109
Misses ? 7657
Partials ? 1071 |
This is an automated cherry-pick of #2252
What problem does this PR solve?
What is changed and how it works?
checkpoint - 1
, to satisfy the open-interval assumption by TiKV.checkpoint
instead ofcheckpoint-1
avoid overlap between listened DDL events and fetched schema snapshot.Check List
Tests
Related changes
Release note