Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: fix new owner updating checkpoint too early with pending DDL (#2252) #2291

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2252

What problem does this PR solve?

What is changed and how it works?

  • Changed the start-ts of DDL puller to checkpoint - 1, to satisfy the open-interval assumption by TiKV.
  • Fetch the snapshot of meta data at checkpoint instead of checkpoint-1 avoid overlap between listened DDL events and fetched schema snapshot.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix potential DDL loss when owner crashes while executing DDL

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved component/ddl DDL component. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Jul 14, 2021
@ti-chi-bot ti-chi-bot requested a review from lonng July 14, 2021 07:58
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 14, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2021
@amyangfei amyangfei added this to the v4.0.15 milestone Jul 15, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 50fa3aa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2291 (0c44694) into release-4.0 (753073a) will increase coverage by 0.6857%.
The diff coverage is 59.3214%.

@@                 Coverage Diff                 @@
##           release-4.0      #2291        +/-   ##
===================================================
+ Coverage      53.7661%   54.4518%   +0.6857%     
===================================================
  Files              153        166        +13     
  Lines            15958      19913      +3955     
===================================================
+ Hits              8580      10843      +2263     
- Misses            6475       8031      +1556     
- Partials           903       1039       +136     

@ti-chi-bot ti-chi-bot merged commit a534d31 into pingcap:release-4.0 Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/ddl DDL component. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants