-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logSink: revert defaultBufferChanSize, add a trigger to flush logSink.units when chennal is full #2431
Conversation
fix bug issue pingcap#1259 reported temporarily
Conflicts: cdc/sink/cdclog/file.go
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Thanks for your contribution! By the way, we lack unit tests in cdc/sink/cdclog, that is quite a problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6ef8d7a
|
/run-integration-tests |
….units when chennal is full (pingcap#2431)
In response to a cherrypick label: new pull request created: #2444. |
….units when chennal is full (pingcap#2431)
In response to a cherrypick label: new pull request created: #2445. |
….units when chennal is full (pingcap#2431)
In response to a cherrypick label: new pull request created: #2446. |
What problem does this PR solve?
1259 2424
What is changed and how it works?
Recover
defaultBufferChanSize
to 20480 which increased by 1469.Add a criterion for refreshing logSink.units, which
sendEvents.Load() == defaultBufferChanSize
, i.e. units chennal is full.Check List
Tests
Code changes
Side effects
Related changes
Release note