Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logSink: revert defaultBufferChanSize, add a trigger to flush logSink.units when chennal is full #2431

Merged
merged 27 commits into from
Aug 2, 2021

Conversation

dengqee
Copy link
Contributor

@dengqee dengqee commented Aug 2, 2021

What problem does this PR solve?

1259 2424

What is changed and how it works?

Recover defaultBufferChanSize to 20480 which increased by 1469.

Add a criterion for refreshing logSink.units, which sendEvents.Load() == defaultBufferChanSize, i.e. units chennal is full.

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

fix a bug where synchronizing large tables to cdclog failed.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 2, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. contribution This PR is from a community contributor. labels Aug 2, 2021
@amyangfei
Copy link
Contributor

amyangfei commented Aug 2, 2021

Thanks for your contribution!

By the way, we lack unit tests in cdc/sink/cdclog, that is quite a problem

@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. type/bugfix This PR fixes a bug. labels Aug 2, 2021
@amyangfei amyangfei added this to the v5.2.0 milestone Aug 2, 2021
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6ef8d7a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2021
@amyangfei amyangfei added the needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. label Aug 2, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei amyangfei added the component/pitr Point-in-time recovery component. label Aug 2, 2021
@ti-chi-bot ti-chi-bot merged commit ad30213 into pingcap:master Aug 2, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 2, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2444.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2445.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2446.

ti-chi-bot added a commit that referenced this pull request Aug 3, 2021
ti-chi-bot added a commit that referenced this pull request Aug 3, 2021
ti-chi-bot added a commit that referenced this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/pitr Point-in-time recovery component. contribution This PR is from a community contributor. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants