Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] capture: make capture info register & unregister atomic. #2432

Closed

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

close #2388

What is changed and how it works?

  • add an atomic variable to control the register and unregister capture info into etcd.
  • fix some lint and typo when wql

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release note

Please add a release note.
If you don't think this PR needs a release note then fill it with `None`.

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 2, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 2, 2021
@3AceShowHand 3AceShowHand changed the title capture: make capture info register & unregister atomic. [DNM] capture: make capture info register & unregister atomic. Aug 2, 2021
@amyangfei amyangfei added the component/replica-model Replication model component. label Aug 2, 2021
@3AceShowHand
Copy link
Contributor Author

close, pr should based on v4.0

@3AceShowHand 3AceShowHand deleted the fix-2388-capture-list branch August 2, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/replica-model Replication model component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture list increased 1 unexpected after all PD restarting
3 participants