Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add check pd alive timeout #3012

Merged
merged 2 commits into from
Oct 14, 2021
Merged

tests: add check pd alive timeout #3012

merged 2 commits into from
Oct 14, 2021

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Close #2993

What is changed and how it works?

check pd startup with timeout

Check List

Tests

  • Unit test
  • Integration test

Release note 

None

@amyangfei amyangfei added component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Oct 11, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2021
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei added this to the v5.3.0 milestone Oct 11, 2021
@amyangfei
Copy link
Contributor Author

/run-kafka-tests

@amyangfei amyangfei added the status/ptal Could you please take a look? label Oct 11, 2021
Rustin170506
Rustin170506 approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 14, 2021
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ffd143d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2021
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #3012 (ffd143d) into master (3c3b915) will increase coverage by 0.0906%.
The diff coverage is 51.3194%.

@@               Coverage Diff                @@
##             master      #3012        +/-   ##
================================================
+ Coverage   57.2251%   57.3157%   +0.0906%     
================================================
  Files           163        188        +25     
  Lines         19453      20736      +1283     
================================================
+ Hits          11132      11885       +753     
- Misses         7261       7661       +400     
- Partials       1060       1190       +130

@ti-chi-bot ti-chi-bot merged commit 075df0f into pingcap:master Oct 14, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3053.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3054.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3055.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3056.

ti-chi-bot added a commit that referenced this pull request Oct 19, 2021
@ti-chi-bot
tests: add check pd alive timeout (#3012) (#3055)
d8bc1e5
ti-chi-bot added a commit that referenced this pull request Oct 19, 2021
@ti-chi-bot
tests: add check pd alive timeout (#3012) (#3054)
b879cc8
ti-chi-bot added a commit that referenced this pull request Oct 19, 2021
@ti-chi-bot
tests: add check pd alive timeout (#3012) (#3056)
e6b6f02
ti-chi-bot added a commit that referenced this pull request Oct 20, 2021
@ti-chi-bot
tests: add check pd alive timeout (#3012) (#3053)
d3d4357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@asddongmen asddongmen asddongmen approved these changes

Assignees
No one assigned
Labels
component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.

integration test get stuck during tidb cluster startup
5 participants
@amyangfei @ti-chi-bot @codecov-commenter @asddongmen @Rustin170506