Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: fix unstable test TestServerWrapperDelayed #3250

Merged

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Nov 3, 2021

What problem does this PR solve?


[2021-11-03T03:03:49.175Z] [2021/11/03 11:01:57.701 +08:00] [INFO] [server_wrapper_test.go:49] ["error received"] [error="rpc error: code = Canceled desc = context canceled"]

[2021-11-03T03:03:49.175Z] --- FAIL: TestServerWrapperDelayed (0.13s)

[2021-11-03T03:03:49.175Z]     server_wrapper_test.go:185: FAIL:	OnNewMessage(*p2p.MessagePacket)

[2021-11-03T03:03:49.175Z]         		at: [server_wrapper_test.go:165]

[2021-11-03T03:03:49.175Z]     server_wrapper_test.go:185: FAIL: 0 out of 1 expectation(s) were met.

[2021-11-03T03:03:49.175Z]         	The code you are testing needs to make 1 more call(s).

[2021-11-03T03:03:49.175Z]         	at: [server_wrapper_test.go:185]

[2021-11-03T03:03:49.175Z] FAIL

What is changed and how it works?

  • This test case should be considered passed only if it does not panic, because we should not require a cancelled gRPC server to handle the request before it exits.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 3, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 3, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Nov 3, 2021

/run-leak-tests

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 3, 2021
@liuzix liuzix added this to the v5.3.0 milestone Nov 3, 2021
@liuzix liuzix added the status/ptal Could you please take a look? label Nov 3, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 3, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1c64543

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 3, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3250 (1c64543) into master (de2fca8) will decrease coverage by 0.0698%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master      #3250        +/-   ##
================================================
- Coverage   56.7226%   56.6528%   -0.0699%     
================================================
  Files           214        214                
  Lines         22915      22915                
================================================
- Hits          12998      12982        -16     
- Misses         8604       8622        +18     
+ Partials       1313       1311         -2     

@ti-chi-bot ti-chi-bot merged commit b5a9d39 into pingcap:master Nov 3, 2021
@liuzix liuzix deleted the zixiong-fix-server-wrapper-delayed branch November 3, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants