New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc/sink: remove Initialize method from the sink interface #3682

Merged

ti-chi-bot merged 4 commits into pingcap:master from 3AceShowHand:remove-sink-initialize

Dec 1, 2021

Contributor

3AceShowHand commented Dec 1, 2021 •

edited

Loading

What problem does this PR solve?

This PR remove the Initialized method from the sink, which is useless.

What is changed and how it works?

Check List

Tests

No code

Code changes

Side effects

Related changes

Release note

 `None`.

Member

ti-chi-bot commented Dec 1, 2021 •

edited

Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

amyangfei
asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot added release-note size/L labels

3AceShowHand force-pushed the remove-sink-initialize branch from 6a409e9 to e7b9795 Compare

December 1, 2021 05:43

Contributor Author

3AceShowHand commented Dec 1, 2021

/run-all-tests

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #3682 (e7b9795) into master (1a4a20e) will increase coverage by 0.0484%.
The diff coverage is n/a.

Flag	Coverage Δ
cdc	`57.4321% <ø> (+0.0982%)`	⬆️
dm	`56.3924% <ø> (+0.0058%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #3682        +/-   ##
================================================
+ Coverage   56.8249%   56.8734%   +0.0484%     
================================================
  Files           456        456                
  Lines         54147      54129        -18     
================================================
+ Hits          30769      30785        +16     
+ Misses        20183      20150        -33     
+ Partials       3195       3194         -1

asddongmen approved these changes

View reviewed changes

ti-chi-bot added the status/LGT1 label

amyangfei approved these changes

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels

Contributor

amyangfei commented Dec 1, 2021

/merge

Member

ti-chi-bot commented Dec 1, 2021

This pull request has been accepted and is ready to merge.

Commit hash: e7b9795

ti-chi-bot added the status/can-merge label

3AceShowHand added 2 commits

December 1, 2021 15:07


          remove Initialize method from the sink.

b3ddd07


          fix make check.

3fed7e4

3AceShowHand force-pushed the remove-sink-initialize branch from e7b9795 to 3fed7e4 Compare

December 1, 2021 07:07

ti-chi-bot added size/XXL and removed status/can-merge size/L labels

3AceShowHand force-pushed the remove-sink-initialize branch from 3983cc6 to 3fed7e4 Compare

December 1, 2021 07:14


          fix rebase issue.

295d7d9

ti-chi-bot added size/M and removed size/XXL labels

Contributor

amyangfei commented Dec 1, 2021

/merge

Member

ti-chi-bot commented Dec 1, 2021

This pull request has been accepted and is ready to merge.

Commit hash: 295d7d9

ti-chi-bot added status/can-merge release-note-none and removed release-note labels

Contributor Author

3AceShowHand commented Dec 1, 2021

/run-dm-integration-test

Contributor Author

3AceShowHand commented Dec 1, 2021

/run-all-tests

1 similar comment

Contributor Author

3AceShowHand commented Dec 1, 2021

/run-all-tests

Contributor Author

3AceShowHand commented Dec 1, 2021

/run-verify-ci

ti-chi-bot merged commit f0c555c into pingcap:master

Contributor Author

3AceShowHand commented Dec 7, 2021

/cherry-pick release-4.0
/cherry-pick release-5.0
/cherry-pick release-5.1
/cherry-pick release-5.2
/cherry-pick release-5.3

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request


          This is an automated cherry-pick of pingcap#3682

a91dcbb

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request

cdc/sink: remove Initialize method from the sink interface (#3682) #3761

Merged

Member

ti-chi-bot commented Dec 7, 2021

@3AceShowHand: new pull request created: #3761.

In response to this:

/cherry-pick release-4.0
/cherry-pick release-5.0
/cherry-pick release-5.1
/cherry-pick release-5.2
/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request


          This is an automated cherry-pick of pingcap#3682

568bbb6

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request

cdc/sink: remove Initialize method from the sink interface (#3682) #3762

Merged

Member

ti-chi-bot commented Dec 7, 2021

@3AceShowHand: new pull request created: #3762.

In response to this:

/cherry-pick release-4.0
/cherry-pick release-5.0
/cherry-pick release-5.1
/cherry-pick release-5.2
/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request


          This is an automated cherry-pick of pingcap#3682

a6407f4

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request

cdc/sink: remove Initialize method from the sink interface (#3682) #3763

Merged

Member

ti-chi-bot commented Dec 7, 2021

@3AceShowHand: new pull request created: #3763.

In response to this:

/cherry-pick release-4.0
/cherry-pick release-5.0
/cherry-pick release-5.1
/cherry-pick release-5.2
/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request


          This is an automated cherry-pick of pingcap#3682

182474f

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request

cdc/sink: remove Initialize method from the sink interface (#3682) #3764

Closed

Member

ti-chi-bot commented Dec 7, 2021

@3AceShowHand: new pull request created: #3764.

In response to this:

/cherry-pick release-4.0
/cherry-pick release-5.0
/cherry-pick release-5.1
/cherry-pick release-5.2
/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request


          cdc/sink: remove Initialize method from the sink interface (pingcap#3682

02491d0

ti-chi-bot mentioned this pull request

cdc/sink: remove Initialize method from the sink interface (#3682) #3765

Merged

Member

ti-chi-bot commented Dec 7, 2021

@3AceShowHand: new pull request created: #3765.

In response to this:

/cherry-pick release-4.0
/cherry-pick release-5.0
/cherry-pick release-5.1
/cherry-pick release-5.2
/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

okJiang pushed a commit to okJiang/tiflow that referenced this pull request


          cdc/sink: remove Initialize method from the sink interface (pingcap#3682

f0f6ddf

ti-chi-bot added a commit that referenced this pull request


          cdc/sink: remove Initialize method from the sink interface (#3682) (#…

0242caf

…3762)

overvenus pushed a commit that referenced this pull request


          cdc/sink: remove Initialize method from the sink interface (#3682) (#…

2d745de

…3765)

Co-authored-by: Ling Jin <[email protected]>

overvenus pushed a commit that referenced this pull request


          cdc/sink: adjust kafka initialization logic (#3192) (#3568)

ba39423

* This is an automated cherry-pick of #3192

Signed-off-by: ti-chi-bot <[email protected]>

* fix conflicts.

* This is an automated cherry-pick of #3682

Signed-off-by: ti-chi-bot <[email protected]>

* fix import.

* fix failpoint path.

* try to fix initialize.

* remove table_sink.

* remove initialization.

* remove owner.

* fix mq.

Co-authored-by: Ling Jin <[email protected]>
Co-authored-by: 3AceShowHand <[email protected]>

3AceShowHand added a commit to ti-chi-bot/tiflow that referenced this pull request


          cdc/sink: adjust kafka initialization logic (pingcap#3192) (pingcap#3568

03a292e

)

* This is an automated cherry-pick of pingcap#3192

Signed-off-by: ti-chi-bot <[email protected]>

* fix conflicts.

* This is an automated cherry-pick of pingcap#3682

Signed-off-by: ti-chi-bot <[email protected]>

* fix import.

* fix failpoint path.

* try to fix initialize.

* remove table_sink.

* remove initialization.

* remove owner.

* fix mq.

Co-authored-by: Ling Jin <[email protected]>
Co-authored-by: 3AceShowHand <[email protected]>

3AceShowHand added a commit to ti-chi-bot/tiflow that referenced this pull request


          cdc/sink: remove Initialize method from the sink interface (pingcap#3682

b55018e

) (pingcap#3765)

Co-authored-by: Ling Jin <[email protected]>

overvenus pushed a commit that referenced this pull request


          cdc/sink: remove Initialize method from the sink interface (#3682) (#…

09d4ae2

…3763)

* This is an automated cherry-pick of #3682

Signed-off-by: ti-chi-bot <[email protected]>

* remove table_sink.go

* add a comment.

* fix make check.

Co-authored-by: Ling Jin <[email protected]>
Co-authored-by: 3AceShowHand <[email protected]>

overvenus pushed a commit that referenced this pull request


          cdc/sink: remove Initialize method from the sink interface (#3682) (#…

769638b

…3761)

* This is an automated cherry-pick of #3682

Signed-off-by: ti-chi-bot <[email protected]>

* remove table_sink.

Co-authored-by: Ling Jin <[email protected]>
Co-authored-by: 3AceShowHand <[email protected]>

overvenus pushed a commit that referenced this pull request


          metrics(cdc): fix mq sink write row count metrics. (#4192) (#4322)

a5ce862

* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ

* address comments

* add comments for exported functions

* fix the compiling problem

* workerpool: limit the rate to output deadlock warning (#3775) (#3799)

* metrics: add changefeed checkepoint catch-up ETA (#3300) (#3311)

* pkg,cdc: do not use log package (#3902) (#3939)

* *: rename repo from pingcap/ticdc to pingcap/tiflow (#3957)

* kvclient(ticdc): fix kvclient takes too long time to recover (#3612) (#3662)

* tz (ticdc): fix timezone error (#3887) (#3910)

* http_*: add log for http api and refine the err handle logic (#2997) (#3306)

* ticdc/alert: add no owner alert rule (#3809) (#3831)

* etcd_worker: batch etcd patch (#3277) (#3393)

* ticdc/owner: Fix ddl special comment syntax error (#3845) (#3977)

* Clean old owner and old processor in release 5.2 branch (#4019)

* tests(ticdc): set up the sync diff output directory correctly (#3725) (#3745)

* owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) (#4015)

* config(ticdc): Fix old value configuration check for maxwell protocol (#3747) (#3782)

* ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4027)

* sink(ticdc): cherry pick sink bug fix to release 5.2 (#4083) (#4119)

* metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (#4103)

* kv(ticdc): reduce eventfeed rate limited log (#4072) (#4110)

close #4006

* This is an automated cherry-pick of #4192

Signed-off-by: ti-chi-bot <[email protected]>

* http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4122)

close #3840

* cdc/sink: adjust kafka initialization logic (#3192) (#3568)

* This is an automated cherry-pick of #3192

Signed-off-by: ti-chi-bot <[email protected]>

* fix conflicts.

* This is an automated cherry-pick of #3682

Signed-off-by: ti-chi-bot <[email protected]>

* fix import.

* fix failpoint path.

* try to fix initialize.

* remove table_sink.

* remove initialization.

* remove owner.

* fix mq.

Co-authored-by: Ling Jin <[email protected]>
Co-authored-by: 3AceShowHand <[email protected]>

* sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (#4084) (#4098)

close #4055

* This is an automated cherry-pick of #4192

Signed-off-by: ti-chi-bot <[email protected]>

* fix conflicts.

* fix conflicts.

* fix conflicts.

Co-authored-by: zhaoxinyu <[email protected]>
Co-authored-by: amyangfei <[email protected]>
Co-authored-by: dongmen <[email protected]>
Co-authored-by: Ling Jin <[email protected]>
Co-authored-by: 3AceShowHand <[email protected]>

ti-chi-bot added a commit to ti-chi-bot/tiflow that referenced this pull request


          metrics(cdc): fix mq sink write row count metrics. (pingcap#4192) (pi…

ae04769

…ngcap#4323)

* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ

* address comments

* add comments for exported functions

* fix the compiling problem

* workerpool: limit the rate to output deadlock warning (pingcap#3775) (pingcap#3795)

* tests(ticdc): set up the sync diff output directory correctly (pingcap#3725) (pingcap#3741)

* relay(dm): use binlog name comparison (pingcap#3710) (pingcap#3712)

* dm/load: fix concurrent call Loader.Status (pingcap#3459) (pingcap#3468)

* cdc/sorter: make unified sorter cgroup aware (pingcap#3436) (pingcap#3439)

* tz (ticdc): fix timezone error (pingcap#3887) (pingcap#3906)

* pkg,cdc: do not use log package (pingcap#3902) (pingcap#3940)

* *: rename repo from pingcap/ticdc to pingcap/tiflow (pingcap#3959)

* http_*: add log for http api and refine the err handle logic (pingcap#2997) (pingcap#3307)

* etcd_worker: batch etcd patch (pingcap#3277) (pingcap#3389)

* http_api (ticdc): check --cert-allowed-cn before add server common name (pingcap#3628) (pingcap#3882)

* kvclient(ticdc): fix kvclient takes too long time to recover (pingcap#3612) (pingcap#3663)

* owner: fix owner tick block http request (pingcap#3490) (pingcap#3530)

* dm/syncer: use downstream PK/UK to generate DML (pingcap#3168) (pingcap#3256)

* dep(dm): update go-mysql (pingcap#3914) (pingcap#3934)

* dm/syncer: multiple rows use downstream schema (pingcap#3308) (pingcap#3953)

* errorutil,sink,syncer: add errorutil to handle ignorable error (pingcap#3264) (pingcap#3995)

* dm/worker: don't exit when failed to read checkpoint in relay (pingcap#3345) (pingcap#4005)

* syncer(dm): use an early location to reset binlog and open safemode (pingcap#3860)

* ticdc/owner: Fix ddl special comment syntax error (pingcap#3845) (pingcap#3978)

* dm/scheduler: fix inconsistent of relay status (pingcap#3474) (pingcap#4009)

* owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingcap#2980) (pingcap#4007) (pingcap#4016)

* config(ticdc): Fix old value configuration check for maxwell protocol (pingcap#3747) (pingcap#3783)

* sink(ticdc): cherry pick sink bug fix to release 5.3 (pingcap#4083)

* master(dm): clean and treat invalid load task (pingcap#4004) (pingcap#4145)

* loader: fix wrong progress in query-status for loader (pingcap#4093) (pingcap#4143)

close pingcap#3252

* ticdc/processor: Fix backoff base delay misconfiguration (pingcap#3992) (pingcap#4028)

* dm: load table structure from dump files (pingcap#3295) (pingcap#4163)

* compactor: fix duplicate entry in safemode (pingcap#3432) (pingcap#3434) (pingcap#4088)

* kv(ticdc): reduce eventfeed rate limited log (pingcap#4072) (pingcap#4111)

close pingcap#4006

* metrics(ticdc): add resolved ts and add changefeed to dataflow (pingcap#4038) (pingcap#4104)

* This is an automated cherry-pick of pingcap#4192

Signed-off-by: ti-chi-bot <[email protected]>

* retry(dm): align with tidb latest error message (pingcap#4172) (pingcap#4254)

close pingcap#4159, close pingcap#4246

* owner(ticdc): Add bootstrap and try to fix the meta information in it (pingcap#3838) (pingcap#3865)

* redolog: add a precleanup process when s3 enable (pingcap#3525) (pingcap#3878)

* ddl(dm): make skipped ddl pass `SplitDDL()` (pingcap#4176) (pingcap#4227)

close pingcap#4173

* cdc/sink: remove Initialize method from the sink interface (pingcap#3682) (pingcap#3765)

Co-authored-by: Ling Jin <[email protected]>

* http_api (ticdc): fix http api 'get processor' panic. (pingcap#4117) (pingcap#4123)

close pingcap#3840

* sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (pingcap#4084) (pingcap#4099)

close pingcap#4055

* cdc/sink: adjust kafka initialization logic (pingcap#3192) (pingcap#4162)

* try fix conflicts.

* This is an automated cherry-pick of pingcap#4192

Signed-off-by: ti-chi-bot <[email protected]>

* fix conflicts.

* fix conflicts.

Co-authored-by: zhaoxinyu <[email protected]>
Co-authored-by: amyangfei <[email protected]>
Co-authored-by: lance6716 <[email protected]>
Co-authored-by: sdojjy <[email protected]>
Co-authored-by: Ling Jin <[email protected]>
Co-authored-by: 3AceShowHand <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none size/M status/can-merge status/LGT2