checker(dm): move checker from tidb-tools to dm #3770
Conversation
…p-master Conflicts: .github/workflows/dm_binlog_999999.yaml .github/workflows/dm_chaos.yaml .github/workflows/dm_upstream_switch.yaml .github/workflows/ticdc_chaos.yaml .github/workflows/ticdc_integration.yaml .github/workflows/upgrade_dm_via_tiup.yaml
fix conflict
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
dm/checker/mysql_server.go
Outdated
| }, | ||
| "mariadb": { | ||
| MySQLVersion{10, 1, 2}, | ||
| MaxVersion, |
There was a problem hiding this comment.
I remember that newer MariaDB doesn't fit DM well. maybe we should be more strict about the version and this check could raise warning not error?
cc @sunzhaoyang
There was a problem hiding this comment.
MariaDB seems to have a very different permission limit than MySQL, I wonder if we can not report MariaDB error.
Or we could just not support MariaDB in pre-check until we sorted out a better MariaDB support scheme.
No modification for the checker. Just move it. @lance6716 So I think the IT passed is enough to merge. |
|
/run-verify |
|
/run-dm-compatibility-test |
|
/run-leak-test |
|
/run-dm-compatibility-test |
dm/checker/binlog.go
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package checker |
There was a problem hiding this comment.
maybe move this package to ticdc/pkg/checker or ticdc/dm/pkg/ ? https://github.com/golang-standards/project-layout#pkg
There was a problem hiding this comment.
done in pingcap/ticdc@7b672e8
|
/run-dm-compatibility-test |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #3770 +/- ##
================================================
+ Coverage 57.3452% 57.5731% +0.2279%
================================================
Files 460 472 +12
Lines 54927 56113 +1186
================================================
+ Hits 31498 32306 +808
- Misses 20180 20524 +344
- Partials 3249 3283 +34 |
|
/run-kafka-integration-test |
|
The CI passed all. ptal again, thank you❤️ @Ehco1996 @lance6716 |
ti-chi-bot
added
status/LGT2
|
/run-dm-compatibility-test |
|
/run-dm-integration-test |
|
/run-dm-integration-test |
2 similar comments
|
/run-dm-integration-test |
|
/run-dm-integration-test |
|
/merge |
|
@okJiang: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: d7b1875
|
ti-chi-bot
added
the
status/can-merge
|
/run-dm-compatibility-test |
|
/run-integration-test |
|
/run-integration-test |
What problem does this PR solve?
close https://github.com/pingcap/ticdc/issues/3768
What is changed and how it works?
Check List
Tests
Release note