-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capture(cdc), tcpserver: integrate P2P with server & capture #3932
capture(cdc), tcpserver: integrate P2P with server & capture #3932
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-integration-tests |
1 similar comment
/run-integration-tests |
/run-leak-tests |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #3932 +/- ##
================================================
- Coverage 57.0741% 55.1442% -1.9300%
================================================
Files 478 484 +6
Lines 56551 59183 +2632
================================================
+ Hits 32276 32636 +360
- Misses 20978 23247 +2269
- Partials 3297 3300 +3 |
5ababae
to
63db282
Compare
/run-integration-tests |
1 similar comment
/run-integration-tests |
/run-verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
c.MessageRouter.Close() | ||
c.MessageRouter.Wait() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we wait in Close
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separating Close
and Wait
in the design of the interface is for two reasons:
- To provide a finer-grained control over the timing of execution to achieve better unit-test coverage.
- To avoid introducing deadlock bugs accidentally in the future. The pattern of
close-wait-close-wait
instead ofclose-close-wait-wait
has created deadlock bugs before.
/run-integration-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 50a444a
|
/run-leak-tests |
/run-kafka-integration-test |
/run-integration-tests |
/run-dm-integration-test |
2 similar comments
/run-dm-integration-test |
/run-dm-integration-test |
test failed due to #4029 |
/run-leak-tests |
@liuzix: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
What is changed and how it works?
pkg/tcpserver
to listen to the port.MessageServer
.MessageServer
,MessageRouter
andServerWrapper
inCapture
.MessageServer
andMessageRouter
intocontext
so that the Owner and Processor can depend on them.SetOnCaptureAdded
andSetOnCaptureRemoved
on the global state reactor so that theMessageRouter
can be informed of capture membership changes.Check List
Tests
Release note