Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test(dm): fix unexpected sync-diff temporarily" #4053

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Revert "test(dm): fix unexpected sync-diff temporarily" #4053

merged 1 commit into from
Dec 24, 2021

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Dec 24, 2021 •
edited
Loading

Reverts #4031

close #4029, because pingcap/tidb-tools#576 has been merged

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 24, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 24, 2021
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Dec 24, 2021
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

1 similar comment
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2021
@lance6716 lance6716 added the require-LGT1 Indicates that the PR requires an LGTM. label Dec 24, 2021
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 71f0a19

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 24, 2021
@Ehco1996
Copy link
Contributor

/run-dm-integration-tests

@ti-chi-bot ti-chi-bot merged commit 741a46f into master Dec 24, 2021
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Dec 29, 2021
@lance6716 @zhaoxinyu
Revert "test(dm): fix unexpected sync-diff temporarily" (pingcap#4053)
98bdc12
@overvenus overvenus deleted the revert-4031-unstable-4029 branch April 19, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okJiang okJiang okJiang approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DM-119 is not stable
4 participants
@lance6716 @ti-chi-bot @Ehco1996 @okJiang