Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker(dm): support optimistic checker #4329

Merged
merged 28 commits into from
Feb 14, 2022
Merged

checker(dm): support optimistic checker #4329

merged 28 commits into from
Feb 14, 2022

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Jan 14, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4328

What is changed and how it works?

  • don't check sharding tables if exist checkpoint
  • support to check optimistic compitible

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note 

Please add a release note.
If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2022
@okJiang okJiang changed the title save work: don't check sharding tables if not exist checkpoint checker(dm): support optimistic checker Jan 14, 2022
@okJiang okJiang added the area/dm Issues or PRs related to DM. label Jan 14, 2022
@okJiang
Copy link
Member Author

okJiang commented Jan 14, 2022

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2022
@okJiang
Copy link
Member Author

okJiang commented Jan 26, 2022

/run-dm-integration-test

@okJiang okJiang marked this pull request as ready for review January 26, 2022 09:10
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2022
Ehco1996
Ehco1996 reviewed Feb 7, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dm/checker/checker.go Outdated Show resolved Hide resolved
dm/checker/checker.go Outdated
break
}
}
if !existCheckpoint {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems you forget the checkingShard options

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkingShard is in L249

dm/pkg/checker/table_structure.go Outdated Show resolved Hide resolved
@okJiang
Copy link
Member Author

okJiang commented Feb 7, 2022

/run-dm-integration-test

@okJiang
Copy link
Member Author

okJiang commented Feb 7, 2022

/run-dm-integration-test

@okJiang
Copy link
Member Author

okJiang commented Feb 11, 2022 •
edited
Loading

all comment fixed, ptal again, thank you @lance6716 @Ehco1996

@okJiang
Copy link
Member Author

okJiang commented Feb 11, 2022

/run-dm-integration-test

Ehco1996
Ehco1996 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 11, 2022
@okJiang
Merge branch 'pre-check-optimistic-shard' of github.com:okJiang/ticdc…
5ba89bf 
…; branch 'master' of github.com:pingcap/tiflow into pre-check-optimistic-shard
@okJiang
Copy link
Member Author

okJiang commented Feb 14, 2022 •
edited
Loading

/hold
need change optimistic-checker to multi-thread.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2022
@okJiang
Copy link
Member Author

okJiang commented Feb 14, 2022

/unhold

/run-all-tests

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2022
@Ehco1996
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6a31f3a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2022
@okJiang
Copy link
Member Author

okJiang commented Feb 14, 2022

/run-kafka-integration-test

@okJiang
Copy link
Member Author

okJiang commented Feb 14, 2022

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 1fb41f9 into pingcap:master Feb 14, 2022
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Feb 16, 2022
@okJiang @zhaoxinyu
checker(dm): support optimistic checker (pingcap#4329)
56e8f4a 
close pingcap#4328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add optimistic compitible table structure check
4 participants
@okJiang @ti-chi-bot @lance6716 @Ehco1996