Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ticdc): add design doc for multiple topics #4422

Merged
merged 10 commits into from
Jan 26, 2022

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Jan 20, 2022

What problem does this PR solve?

Issue Number: ref #4423

What is changed and how it works?

add design doc for multiple topics.

rendered

Check List

Tests

  • No code

Code changes

None

Side effects

None

Related changes

None

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jan 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022

Codecov Report

Merging #4422 (9423549) into master (9607554) will decrease coverage by 0.0163%.
The diff coverage is 24.7311%.

Flag Coverage Δ
cdc 59.9390% <42.8571%> (+0.0168%) ⬆️
dm 52.0056% <21.5189%> (-0.0233%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4422        +/-   ##
================================================
- Coverage   55.6402%   55.6238%   -0.0164%     
================================================
  Files           494        495         +1     
  Lines         61283      61186        -97     
================================================
- Hits          34098      34034        -64     
+ Misses        23750      23726        -24     
+ Partials       3435       3426         -9     

Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work with the schema registry? will the topics match the names in the registry? or is it outside of the scope of this design?

Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be used to match the current schema registry naming. The later on prefix support needs to be added that is compatible with registry naming

@ti-chi-bot
Copy link
Member

@dveeden: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

I think this can be used to match the current schema registry naming. The later on prefix support needs to be added that is compatible with registry naming

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member Author

How does this work with the schema registry? will the topics match the names in the registry? or is it outside of the scope of this design?

Yes, it's a bit out the scope of this design. It's mainly for multi-topic support. arvo's registry is not in consideration. Thanks for the review. We will discuss more about improving the arvo protocol with you in the near future.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 26, 2022
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9423549

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022
@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit 462074a into pingcap:master Jan 26, 2022
@Rustin170506 Rustin170506 deleted the rustin-patch-docs-topics branch August 15, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants