Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncer(dm): Fix async flush log message #4500

Merged
merged 3 commits into from
Feb 7, 2022
Merged

syncer(dm): Fix async flush log message #4500

merged 3 commits into from
Feb 7, 2022

Conversation

db-will
Copy link
Contributor

@db-will db-will commented Feb 4, 2022 •
edited by lance6716
Loading

What problem does this PR solve?

Issue Number: ref #4287

What is changed and how it works?

Fixed the wrong log message about checkpoint point

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note 

Please add a release note.
If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 4, 2022
@lance6716 lance6716 added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Feb 5, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 5, 2022
@lance6716 lance6716 added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 5, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3134f94

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 5, 2022
@lance6716
Copy link
Contributor

/run-integration-test
/run-kafka-integration-test

@lance6716
Copy link
Contributor

/check-issue-triage-complete

@lance6716
Copy link
Contributor

/check-issue-triage-complete
/run-integration-test
/run-kafka-integration-test

@glorv
Copy link
Contributor

glorv commented Feb 7, 2022

/run-integration-test
/run-kafka-integration-test

@ti-chi-bot
Copy link
Member

@db-will: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b0f52af into pingcap:master Feb 7, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 7, 2022
@db-will @ti-chi-bot
This is an automated cherry-pick of pingcap#4500
745b501 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 7, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4513.

@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Feb 9, 2022
ti-chi-bot added a commit that referenced this pull request Feb 28, 2022
@ti-chi-bot
syncer(dm): Fix async flush log message (#4500) (#4513)
8af9280 
ref #4287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@glorv glorv Awaiting requested review from glorv

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@db-will @ti-chi-bot @lance6716 @glorv