Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(ticdc): enable hibernate-regions-compatible by default #4583

Merged
merged 6 commits into from
Mar 25, 2022

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Feb 14, 2022

Signed-off-by: qupeng [email protected]

What problem does this PR solve?

Issue Number: close #4461

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #4583 (e1691fb) into master (9607554) will decrease coverage by 0.0271%.
The diff coverage is 62.1148%.

Flag Coverage Δ
cdc 60.3402% <59.3750%> (+0.4180%) ⬆️
dm 51.5645% <63.1317%> (-0.4644%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4583        +/-   ##
================================================
- Coverage   55.6402%   55.6131%   -0.0272%     
================================================
  Files           494        504        +10     
  Lines         61283      62176       +893     
================================================
+ Hits          34098      34578       +480     
- Misses        23750      24145       +395     
- Partials       3435       3453        +18     

@hicqu
Copy link
Contributor Author

hicqu commented Feb 14, 2022

/run-integration-test

@hicqu
Copy link
Contributor Author

hicqu commented Feb 14, 2022

/run-integration-test

@hicqu
Copy link
Contributor Author

hicqu commented Feb 16, 2022

/run-integration-test

@hicqu
Copy link
Contributor Author

hicqu commented Feb 23, 2022

/run-integration-test

@overvenus overvenus changed the title enable hibernate-regions-compatible by default tests(ticdc): enable hibernate-regions-compatible by default Mar 3, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 3, 2022
@overvenus overvenus added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 25, 2022
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 86a1a35

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@ti-chi-bot ti-chi-bot merged commit 9ec956f into pingcap:master Mar 25, 2022
@hicqu hicqu deleted the enable-hibernate-compatible branch March 25, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiflash integration fails when hibernate-regions-compatible enabled
4 participants