Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc(sink): remove useless AppendResolvedEvent #4596

Merged
merged 5 commits into from
Feb 15, 2022
Merged

ticdc(sink): remove useless AppendResolvedEvent #4596

merged 5 commits into from
Feb 15, 2022

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: ref #4423

What is changed and how it works?

Remove useless AppendResolvedEvent API.

Most protocols don't implement it, and its original purpose was to ensure the order of dml and ddl. But now buffersink already guarantees it. So we can remove it.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects
None

Related changes

None

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2022
@Rustin170506
Copy link
Member Author

/run-all-tests

@Mini256
Copy link
Member

Mini256 commented Feb 15, 2022

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2022
@Rustin170506
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 15, 2022
@liuzix
Copy link
Contributor

liuzix commented Feb 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 107bddf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2022
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f82df79

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2022
@Rustin170506
Copy link
Member Author

/run-verify

@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit 2293dc2 into pingcap:master Feb 15, 2022
@Rustin170506 Rustin170506 deleted the rustin-patch-sink-useless branch February 15, 2022 13:14
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Feb 16, 2022
@Rustin170506 @zhaoxinyu
ticdc(sink): remove useless AppendResolvedEvent (pingcap#4596)
653af8e 
ref pingcap#4423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@asddongmen asddongmen asddongmen approved these changes

@liuzix liuzix Awaiting requested review from liuzix

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rustin170506 @ti-chi-bot @Mini256 @liuzix @overvenus @asddongmen