-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: support multi-k8s in grafana dashboards #4658
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #4658 +/- ##
================================================
- Coverage 55.6402% 54.9733% -0.6669%
================================================
Files 494 512 +18
Lines 61283 63649 +2366
================================================
+ Hits 34098 34990 +892
- Misses 23750 25166 +1416
- Partials 3435 3493 +58 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6de8d26
|
/run-check-issue-triage-complete |
/merge |
/merge |
/hold |
Signed-off-by: just1900 <[email protected]>
f7efafd
to
821f680
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 821f680
|
/run-integration-test |
@just1900: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4705. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4706. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4707. |
In response to a cherrypick label: new pull request created: #4708. |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4709. |
Signed-off-by: just1900 [email protected]
What problem does this PR solve?
K8s community and organizations are increasingly deploying multiple Kubernetes clusters to improve availability, isolation and scalability. Since TiDB Operator have support deploying tidb across-kubernetes, this PR will address the multi-k8s issue without affecting existing single-cluster use case.
Issue Number: close #4665
What is changed and how it works?
What's Changed:
How it works:
kubernetes
label to identify k8s cluster in your prometheus'external_labels
.sed -i s/"hide": 2/"hide": 0/g <path/to/dashboard.json>
Check List
Tests
Code changes
Side effects
Related changes
Release note