Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): add topic manager #4810

Merged
merged 17 commits into from
Mar 12, 2022
Merged

sink(ticdc): add topic manager #4810

merged 17 commits into from
Mar 12, 2022

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Mar 8, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4423

What is changed and how it works?

  • add topic manager. It is responsible for creating and tracking information about topics.
  • Add GetTopic and GetPartition methods to event router.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Side effects

None

Related changes

None

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus
  • zhaoxinyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 8, 2022
@Rustin170506 Rustin170506 marked this pull request as draft March 8, 2022 09:01
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 8, 2022
@Rustin170506 Rustin170506 force-pushed the rustin-patch-sink-topic-manager branch 2 times, most recently from d8d37a4 to 9102b64 Compare March 9, 2022 10:06
@Rustin170506 Rustin170506 force-pushed the rustin-patch-sink-topic-manager branch from 9f2948e to 8c51e5b Compare March 9, 2022 10:15
@Rustin170506 Rustin170506 marked this pull request as ready for review March 9, 2022 10:18
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2022
@Rustin170506 Rustin170506 force-pushed the rustin-patch-sink-topic-manager branch from 37a2a2e to 2010ada Compare March 9, 2022 11:07
Rustin170506
Rustin170506 commented Mar 9, 2022
View reviewed changes
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self check

@Rustin170506 Rustin170506 added area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. labels Mar 9, 2022
@Rustin170506
Copy link
Member Author

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022 •
edited
Loading

Codecov Report

Merging #4810 (27bbd15) into master (9607554) will increase coverage by 0.3978%.
The diff coverage is 70.9279%.

Flag Coverage Δ
cdc 60.4499% <70.9279%> (+0.5277%) ⬆️
dm 52.4222% <ø> (+0.3933%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4810        +/-   ##
================================================
+ Coverage   55.6402%   56.0380%   +0.3977%     
================================================
  Files           494        523        +29     
  Lines         61283      65427      +4144     
================================================
+ Hits          34098      36664      +2566     
- Misses        23750      25181      +1431     
- Partials       3435       3582       +147

@Rustin170506 Rustin170506 force-pushed the rustin-patch-sink-topic-manager branch 2 times, most recently from 0be2667 to d10acad Compare March 10, 2022 11:20
@Rustin170506
Copy link
Member Author

/run-all-tests

@Rustin170506
Copy link
Member Author

Thanks for your review! 💚 💙 💜 💛 ❤️

@Rustin170506
Copy link
Member Author

/run-all-tests

@Rustin170506
Copy link
Member Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2022
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e6ba54f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2022
@ti-chi-bot
Copy link
Member

@hi-rustin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

1 similar comment
@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit 7b955b5 into pingcap:master Mar 12, 2022
@Rustin170506 Rustin170506 deleted the rustin-patch-sink-topic-manager branch August 15, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@zhaoxinyu zhaoxinyu zhaoxinyu approved these changes

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rustin170506 @ti-chi-bot @codecov-commenter @overvenus @zhaoxinyu