Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p,processor(cdc): fix two unstable tests #4827

Merged
merged 5 commits into from
Mar 14, 2022

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Mar 9, 2022

What problem does this PR solve?

Issue Number: close #3945 close #4319

What is changed and how it works?

  • Fix incorrect assertions in unit tests

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2022
@liuzix
Copy link
Contributor Author

liuzix commented Mar 9, 2022

/run-check-issue-triage-complete

@liuzix
Copy link
Contributor Author

liuzix commented Mar 9, 2022

/run-leak-tests

@liuzix
Copy link
Contributor Author

liuzix commented Mar 10, 2022

/run-leak-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2022

Codecov Report

Merging #4827 (aa3e366) into master (9607554) will increase coverage by 0.6795%.
The diff coverage is 70.9349%.

Flag Coverage Δ
cdc 61.0025% <70.9349%> (+1.0802%) ⬆️
dm 52.4695% <ø> (+0.4406%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4827        +/-   ##
================================================
+ Coverage   55.6402%   56.3198%   +0.6795%     
================================================
  Files           494        523        +29     
  Lines         61283      65524      +4241     
================================================
+ Hits          34098      36903      +2805     
- Misses        23750      25028      +1278     
- Partials       3435       3593       +158     

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2022
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: aa3e366

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@ti-chi-bot ti-chi-bot merged commit 0a4fc06 into pingcap:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test:process/agent_test.go. TestAgentBasics Flaking Test:TestClientSendAnomalies
5 participants