Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): add batch buffer for flush worker #4884

Merged
merged 11 commits into from
Mar 15, 2022

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: ref #4423

What is changed and how it works?

add batch buffer for flush worker. Avoid frequent memory allocation here.

Check List

Tests

  • Unit test

Code changes

None

Side effects

None

Related changes

None

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2022
@Rustin170506 Rustin170506 added area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. labels Mar 14, 2022
cdc/sink/mq_flush_worker.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2022
@Rustin170506 Rustin170506 force-pushed the rustin-patch-sink-flush-worker branch from d6c544e to ed3113a Compare March 15, 2022 03:00
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bca7121

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@Rustin170506
Copy link
Member Author

/run-verify

@codecov-commenter
Copy link

Codecov Report

Merging #4884 (c210381) into master (687e248) will increase coverage by 0.1761%.
The diff coverage is 58.5421%.

❗ Current head c210381 differs from pull request most recent head 5c069f9. Consider uploading reports for the commit 5c069f9 to get more accurate results

Flag Coverage Δ
cdc 60.9722% <59.1240%> (+0.3736%) ⬆️
dm 52.4596% <50.0000%> (-0.0100%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4884        +/-   ##
================================================
+ Coverage   56.1240%   56.3001%   +0.1761%     
================================================
  Files           522        524         +2     
  Lines         65325      65522       +197     
================================================
+ Hits          36663      36889       +226     
+ Misses        25094      25031        -63     
- Partials       3568       3602        +34     

@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

@ti-chi-bot
Copy link
Member

@hi-rustin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member Author

/run-kafka-integration-test
/run-verify

@overvenus
Copy link
Member

/run-verify

@ti-chi-bot ti-chi-bot merged commit c23946f into pingcap:master Mar 15, 2022
@Rustin170506 Rustin170506 deleted the rustin-patch-sink-flush-worker branch August 15, 2022 03:17
@Rustin170506 Rustin170506 restored the rustin-patch-sink-flush-worker branch August 15, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants