Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(ticdc): add multi topic kafka test #4968

Merged
merged 9 commits into from
Mar 22, 2022
Merged

tests(ticdc): add multi topic kafka test #4968

merged 9 commits into from
Mar 22, 2022

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Mar 21, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4423

What is changed and how it works?

  • add multi topic kafka test(canal-json)
  • mount the tests dir into docker
  • refine the stupid code

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

None

Release note 


None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus
  • zhaoxinyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 21, 2022
@Rustin170506 Rustin170506 added area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. labels Mar 21, 2022
@Rustin170506
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022
overvenus
overvenus approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

cdc/owner/changefeed.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2022
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 953a26f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2022
@ti-chi-bot ti-chi-bot merged commit 17b3b26 into pingcap:master Mar 22, 2022
@Rustin170506 Rustin170506 deleted the rustin-patch-sink-multi-topic branch March 22, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoxinyu zhaoxinyu zhaoxinyu approved these changes

@overvenus overvenus overvenus approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rustin170506 @ti-chi-bot @overvenus @zhaoxinyu