Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM(syncer): fix lost lost dml under special sharding ddls (#5006) #5028

Merged
merged 5 commits into from
Mar 25, 2022
Merged

DM(syncer): fix lost lost dml under special sharding ddls (#5006) #5028

merged 5 commits into from
Mar 25, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5006

What problem does this PR solve?

Issue Number: close #5002

What is changed and how it works?

Change the check method of whether sync dml to be active ddl >= dml.

Check List

Tests

  • Integration test

Release note 

None

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 25, 2022
Merged
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. area/dm Issues or PRs related to DM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.0 This PR is cherry-picked to release-6.0 from a source PR. labels Mar 25, 2022
@WizardXiao
Copy link
Contributor

/run-all-tests

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 25, 2022
@WizardXiao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@WizardXiao: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: e658b47

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@WizardXiao
Copy link
Contributor

/run-verify-ci

@WizardXiao
Copy link
Contributor

/run-dm-integration-test

@WizardXiao
Copy link
Contributor

/run-verify-ci

@WizardXiao
Copy link
Contributor

/run-unit-test

@WizardXiao
Copy link
Contributor

/run-verify-ci

@WizardXiao
Copy link
Contributor

/run-unit-test

@WizardXiao
Copy link
Contributor

/run-all-tests

@WizardXiao
Copy link
Contributor

/run-leak-test

@WizardXiao
Copy link
Contributor

/run-dm-integration-test

@WizardXiao
Copy link
Contributor

/run-leak-test

@ti-chi-bot ti-chi-bot merged commit 865301e into pingcap:release-6.0 Mar 25, 2022
@overvenus overvenus added this to the v6.0.0 milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@WizardXiao WizardXiao

Labels
area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.0 This PR is cherry-picked to release-6.0 from a source PR.
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @WizardXiao @lance6716 @overvenus @VelocityLight