checkpoint(dm): check outdated should respect snapshot create time

[lance6716]

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: close #5063

What is changed and how it works?

Old CheckGlobalPoint didn't check Snapshot creating time. Because we always use Snapshot to do a flush no matter it's a sync or async flush, we can always check that time

Check List

Tests

• Unit test

Code changes

• Has interface methods change

Side effects

Related changes

• Need to cherry-pick to the release branch

Release note

Fix a bug that checkpoint flushing will be called too frequently

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• Ehco1996
• lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov-commenter]

Codecov Report

Merging #5160 (e1d675b) into master (687e248) will decrease coverage by 0.0672%.
The diff coverage is 57.1346%.

Flag	Coverage Δ
cdc	60.8333% <52.7915%> (+0.2347%)	⬆️
dm	52.2785% <76.5822%> (-0.1911%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5160        +/-   ##
================================================
- Coverage   56.1240%   56.0568%   -0.0672%     
================================================
  Files           522        526         +4     
  Lines         65325      68031      +2706     
================================================
+ Hits          36663      38136      +1473     
- Misses        25094      26156      +1062     
- Partials       3568       3739       +171     

[Ehco1996]

LGTM

[lance6716]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: e0c0656

[lance6716]

/run-leak-test

[lance6716]

/run-dm-integration-test

[lance6716]

/run-dm-integration-test

keepalive is 1s so caused an unstable test

[lance6716]

/run-dm-integration-test
/run-verify

[lance6716]

/run-dm-integration-test
/run-dm-compatibility-test

[lance6716]

/run-verify

[lance6716]

/run-verify

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5201.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5202.