Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracker(dm): fix tracker panic when pk of downstream table orders behind #5165

Merged
merged 3 commits into from
Apr 14, 2022
Merged

tracker(dm): fix tracker panic when pk of downstream table orders behind #5165

merged 3 commits into from
Apr 14, 2022

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #5159

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note 

fix tracker panic when pk of downstream table orders behind

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2022
@D3Hunter D3Hunter added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2022
@D3Hunter
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2022
@lance6716
Copy link
Contributor

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 13, 2022
@D3Hunter
Copy link
Contributor Author

/run-all-tests

@D3Hunter
Copy link
Contributor Author

/run-leak-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2022
GMHDBJD
GMHDBJD approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@D3Hunter
Copy link
Contributor Author

/run-dm-integration-test
/run-verify

@D3Hunter
Copy link
Contributor Author

/run-dm-integration-test

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 13, 2022
@D3Hunter D3Hunter assigned D3Hunter and unassigned D3Hunter Apr 13, 2022
@D3Hunter
Copy link
Contributor Author

/run-all-tests

@D3Hunter
Copy link
Contributor Author

/run-unit-test

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.3@2605a84). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.3      #5165   +/-   ##
================================================
  Coverage               ?   55.7858%           
================================================
  Files                  ?        222           
  Lines                  ?      23791           
  Branches               ?          0           
================================================
  Hits                   ?      13272           
  Misses                 ?       9168           
  Partials               ?       1351

@D3Hunter D3Hunter removed the needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. label Apr 14, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 614800e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@D3Hunter
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 022c581 into pingcap:release-5.3 Apr 14, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Apr 14, 2022
@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#5165
889797c 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 14, 2022
Merged
2 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5167.

@D3Hunter D3Hunter deleted the fix-tracker-panic branch April 14, 2022 07:29
@D3Hunter D3Hunter mentioned this pull request Apr 14, 2022
Merged
2 tasks
ti-chi-bot added a commit that referenced this pull request Apr 14, 2022
@ti-chi-bot
tracker(dm): fix tracker panic when pk of downstream table orders beh…
b20132f 
…ind (#5165) (#5167)

close #5159
@D3Hunter D3Hunter added the area/dm Issues or PRs related to DM. label May 20, 2022
@heibaijian heibaijian added this to the v5.3.2 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.3.2
Development

Successfully merging this pull request may close these issues.
8 participants
@D3Hunter @ti-chi-bot @lance6716 @codecov-commenter @Ehco1996 @GMHDBJD @heibaijian @zhouqiang-cl