Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracker(dm): close and recreate tracker when pause and resume #5350

Merged
merged 53 commits into from
May 13, 2022
Merged

tracker(dm): close and recreate tracker when pause and resume #5350

merged 53 commits into from
May 13, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented May 7, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5344
fix #3734

What is changed and how it works?

as title. And when (re)create tracker, load all table structure from checkpoints

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note 

Fix a bug that after auto resume, DM will use more disk space.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2022
@lance6716 lance6716 added area/dm Issues or PRs related to DM. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2022
@lance6716
change unistore settings
c2f54f4 
Signed-off-by: lance6716 <[email protected]>
@lance6716
add IT
134bd55 
Signed-off-by: lance6716 <[email protected]>
@lance6716
reset schema tracker every time
4c3ba73 
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2022
@lance6716 lance6716 changed the title --wip-- [skip ci] tracker(dm): close and recreate tracker when pause and resume May 7, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. and removed do-not-merge/needs-linked-issue labels May 7, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
fix CI
6493a50 
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
try fix UT
ba10208 
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
try fix CI
350d7f4 
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

PTAL @lichunzhu

lichunzhu
lichunzhu approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 983b24c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit f3bf091 into pingcap:master May 13, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 13, 2022
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#5350
a7d5fb8 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5415.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 13, 2022
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#5350
6eb6eb4 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5416.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 13, 2022
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#5350
03e1518 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5417.

D3Hunter
D3Hunter reviewed May 13, 2022
View reviewed changes
dm/pkg/utils/db.go
Comment on lines +677 to +678
sql = strings.ReplaceAll(sql, "\n", "")
sql = strings.ReplaceAll(sql, " ", " ")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if there are column defaults contains those char.

seems only used in get schema, ok for now.

lance6716 added a commit to lance6716/ticdc that referenced this pull request May 13, 2022
@lance6716
tracker(dm): close and recreate tracker when pause and resume (pingca…
70185a7 
…p#5350)

close pingcap#5344
lance6716 added a commit that referenced this pull request May 13, 2022
@lance6716
tracker(dm): close and recreate tracker when pause and resume (#5350) (…
109c546 
…#5419)

* tracker(dm): close and recreate tracker when pause and resume (#5350)

close #5344

* fix cherry-pick

Signed-off-by: lance6716 <[email protected]>
@lance6716 lance6716 mentioned this pull request May 13, 2022
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 30, 2022
@lance6716 @ti-chi-bot
tracker(dm): close and recreate tracker when pause and resume (pingca…
6064f43 
…p#5350)

close pingcap#5344
This was referenced May 30, 2022
Merged
Closed
ti-chi-bot added a commit that referenced this pull request Jun 15, 2022
@ti-chi-bot
tracker(dm): close and recreate tracker when pause and resume (#5350) (…
74ac962 
…#5419) (#5636)

close #5344
ti-chi-bot added a commit that referenced this pull request Jun 16, 2022
@ti-chi-bot
tracker(dm): close and recreate tracker when pause and resume (#5350) (…
060e880 
…#5415)

close #5344
@dsdashun dsdashun mentioned this pull request Jun 24, 2022
Closed
@lance6716 lance6716 deleted the fix-unistore-usage branch October 13, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter left review comments

@lichunzhu lichunzhu lichunzhu approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
5 participants
@lance6716 @ti-chi-bot @D3Hunter @GMHDBJD @lichunzhu