Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/chdelay: implement ChannelDelayer #5373

Merged
merged 4 commits into from
May 12, 2022
Merged

pkg/chdelay: implement ChannelDelayer #5373

merged 4 commits into from
May 12, 2022

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented May 10, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #5326

What is changed and how it works?

  • We need a mechanism to reproduce the panic in panic: checkpointTs regressed #5326.
  • I added a helper utility that can delay the messages in a channel by a time interval.
  • Code in this PR will not be run in production.

Check List

Tests

  • Unit test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@liuzix liuzix added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2022
@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2022
@liuzix liuzix changed the title [DNM] pkg/chdelay: implement ChannelDelayer pkg/chdelay: implement ChannelDelayer May 12, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 12, 2022
@liuzix liuzix removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2022 •
edited
Loading

Codecov Report

Merging #5373 (20484b4) into master (687e248) will decrease coverage by 0.0805%.
The diff coverage is 52.6616%.

Flag Coverage Δ
cdc 61.0946% <52.6616%> (+0.4960%) ⬆️
dm 52.1128% <ø> (-0.3567%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5373        +/-   ##
================================================
- Coverage   56.1240%   56.0435%   -0.0806%     
================================================
  Files           522        528         +6     
  Lines         65325      69430      +4105     
================================================
+ Hits          36663      38911      +2248     
- Misses        25094      26810      +1716     
- Partials       3568       3709       +141

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2022
@liuzix
Copy link
Contributor Author

liuzix commented May 12, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 20484b4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2022
@liuzix
Copy link
Contributor Author

liuzix commented May 12, 2022

/run-all-tests

@ti-chi-bot
Copy link
Member

@liuzix: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@liuzix
Copy link
Contributor Author

liuzix commented May 12, 2022

/run-kafka-integration-test

@liuzix
Copy link
Contributor Author

liuzix commented May 12, 2022

/run-integration-tests

@liuzix
Copy link
Contributor Author

liuzix commented May 12, 2022

/run-kafka-integration-test

@liuzix
Copy link
Contributor Author

liuzix commented May 12, 2022

/run-kafka-integration-test

@amyangfei amyangfei merged commit 6b07e48 into pingcap:master May 12, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5405.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdojjy sdojjy sdojjy approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liuzix @ti-chi-bot @codecov-commenter @lance6716 @sdojjy @amyangfei