Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc(codec): add avro refactor design #5413

Merged
merged 8 commits into from
May 18, 2022

Conversation

zhangyangyu
Copy link
Member

@zhangyangyu zhangyangyu commented May 12, 2022

What problem does this PR solve?

Issue Number: ref #5338

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • leoppro
  • zhaoxinyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 12, 2022
@zhangyangyu
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #5413 (a6c9702) into master (687e248) will decrease coverage by 0.2020%.
The diff coverage is 51.3665%.

Flag Coverage Δ
cdc 60.9609% <51.3665%> (+0.3623%) ⬆️
dm 51.9602% <ø> (-0.5093%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5413        +/-   ##
================================================
- Coverage   56.1240%   55.9219%   -0.2021%     
================================================
  Files           522        528         +6     
  Lines         65325      69935      +4610     
================================================
+ Hits          36663      39109      +2446     
- Misses        25094      27101      +2007     
- Partials       3568       3725       +157     

@zhangyangyu
Copy link
Member Author

/run-all-tests

@zhangyangyu
Copy link
Member Author

/run-verify

Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2022
@zier-one
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9033520

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2022
@ti-chi-bot
Copy link
Member

@zhangyangyu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit dd0ee80 into pingcap:master May 18, 2022
@zhangyangyu zhangyangyu mentioned this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants