Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui(dm): spec v3 updates #5447

Merged
merged 10 commits into from
May 18, 2022
Merged

ui(dm): spec v3 updates #5447

merged 10 commits into from
May 18, 2022

Conversation

zoubingwu
Copy link
Member

@zoubingwu zoubingwu commented May 17, 2022 •
edited by WizardXiao
Loading

What problem does this PR solve?

  • Show pre-check warning when create/update task
  • Start task with parameters

Issue Number: ref #5442

Check List

Tests

  • Unit test
  • Integration test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WizardXiao
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #5447 (f0793b4) into master (687e248) will decrease coverage by 0.3548%.
The diff coverage is 51.8728%.

Flag Coverage Δ
cdc 60.6793% <51.8728%> (+0.0807%) ⬆️
dm 51.9493% <ø> (-0.5202%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5447        +/-   ##
================================================
- Coverage   56.1240%   55.7692%   -0.3549%     
================================================
  Files           522        528         +6     
  Lines         65325      69637      +4312     
================================================
+ Hits          36663      38836      +2173     
- Misses        25094      27074      +1980     
- Partials       3568       3727       +159

@WizardXiao WizardXiao mentioned this pull request May 18, 2022
Closed
5 tasks
baurine
baurine reviewed May 18, 2022
View reviewed changes
dm/ui/src/pages/migration/task/index.tsx
Comment on lines +484 to +495
useEffect(() => {
showMessage(startTaskResult)
}, [startTaskResult.status])

useEffect(() => {
showMessage(stopTaskResult)
}, [stopTaskResult.status])

useEffect(() => {
showMessage(deleteTaskResult)
}, [deleteTaskResult.status])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt these 3 useEffect will cause hook dependency lint warning.

baurine
baurine approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@baurine baurine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

@baurine: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

WizardXiao
WizardXiao reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@WizardXiao WizardXiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't find any obvious problems，just some notes need to adjust.

dm/ui/src/models/task.ts
source_name_list?: string[]

/**
* RFC3339 format date string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to record format is like 2006-01-02T15:04:05 or 2006-01-02T15:04:05 and will give UTC time value to backend.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2022
lichunzhu
lichunzhu approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2022
@zoubingwu
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@zoubingwu: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@WizardXiao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c3d8669

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2022
@WizardXiao WizardXiao added the area/dm Issues or PRs related to DM. label May 18, 2022
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 18, 2022
@WizardXiao
Copy link
Contributor

/merge

@WizardXiao
Copy link
Contributor

/run-dm-integration-test

@WizardXiao
Copy link
Contributor

/run-verify-ci

@WizardXiao
Copy link
Contributor

/run-dm-integration-test

@WizardXiao
Copy link
Contributor

/run-verify-ci

@ti-chi-bot ti-chi-bot merged commit dc975b4 into pingcap:master May 18, 2022
@zoubingwu zoubingwu deleted the dev branch May 18, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WizardXiao WizardXiao WizardXiao approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@baurine baurine baurine approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zoubingwu @ti-chi-bot @codecov-commenter @WizardXiao @baurine @lichunzhu