pkg/pdutil(ticdc): fix a deadlock issue #7219
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-triage-completed
release-note-none
|
/run-all-tests |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 69406c2
|
ti-chi-bot
added
the
status/can-merge
| c.cancel() | ||
| c.mu.Unlock() |
There was a problem hiding this comment.
Do we need to add a unit test
There was a problem hiding this comment.
Actually, this will fix that unstable test. So I don't think we need to add a new test.
|
/run-all-tests |
|
@hi-rustin: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-verify |
What problem does this PR solve?
Issue Number: close #7201
What is changed and how it works?
Fix a deadlock issue. Release the lock as soon as possible, otherwise
RunandClosewill cause a deadlock.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note