Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker(engine/dm): no need extStorage if sync is not fresh #7319

Merged
merged 5 commits into from
Oct 12, 2022
Merged

worker(engine/dm): no need extStorage if sync is not fresh #7319

merged 5 commits into from
Oct 12, 2022

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Oct 11, 2022

What problem does this PR solve?

Issue Number: ref #7304

What is changed and how it works?

  • add NoNeedExtStorage in TaskCfg(true when sync is not fresh)
  • do not OpenStorage if NoNeedExtStorage
  • use TaskCfg rather than SubTaskCfg to CreateWorker

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 11, 2022
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 11, 2022
@GMHDBJD GMHDBJD added status/ptal Could you please take a look? area/engine Issues or PRs related to Dataflow Engine. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 11, 2022
@lance6716
Copy link
Contributor

related to #6784 (comment) ?

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 11, 2022

related to #6784 (comment) ?

Yes, but not completely resolved it, we need discard storage.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 11, 2022
lance6716
lance6716 approved these changes Oct 12, 2022
View reviewed changes
engine/executor/dm/worker.go Outdated
@@ -135,7 +137,7 @@ func (w *dmWorker) InitImpl(ctx context.Context) error {
if err := w.messageAgent.UpdateClient(w.masterID, w); err != nil {
return err
}
if w.cfg.Mode != dmconfig.ModeIncrement {
if w.cfg.Mode != dmconfig.ModeIncrement && !w.noNeedExtStorage {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use needExtStorage? double negative is a bit hard to think

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2022
@amyangfei
Copy link
Contributor

/run-engine-integration-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2022
@amyangfei
Copy link
Contributor

Will there be more PRs to fix #7304 for scenario that error happens between dump and load tasks?

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a508ac4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2022
@ti-chi-bot
Copy link
Member

@GMHDBJD: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/run-verify

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 12, 2022

Will there be more PRs to fix #7304 for scenario that error happens between dump and load tasks?

It's difficult, unless we dump it again when the load failed

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 12, 2022

/run-verify

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022 •
edited
Loading

Codecov Report

Merging #7319 (70f2241) into master (2843d67) will increase coverage by 0.3729%.
The diff coverage is 64.5161%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.9669% <70.8215%> (+0.7472%) ⬆️
dm 52.0351% <41.1764%> (+0.1300%) ⬆️
engine 60.9378% <55.7508%> (-0.1197%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7319        +/-   ##
================================================
+ Coverage   59.6477%   60.0207%   +0.3729%     
================================================
  Files           790        799         +9     
  Lines         91016      91625       +609     
================================================
+ Hits          54289      54994       +705     
+ Misses        31982      31871       -111     
- Partials       4745       4760        +15

@ti-chi-bot ti-chi-bot merged commit 84cb040 into pingcap:master Oct 12, 2022
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Oct 12, 2022
@GMHDBJD @3AceShowHand
worker(engine/dm): no need extStorage if sync is not fresh (pingcap#7319
e01a827 
)

ref pingcap#7304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@amyangfei amyangfei amyangfei approved these changes

@CharlesCheung96 CharlesCheung96 Awaiting requested review from CharlesCheung96

Assignees
No one assigned
Labels
area/engine Issues or PRs related to Dataflow Engine. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GMHDBJD @ti-chi-bot @lance6716 @amyangfei @codecov-commenter