Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric(ticdc): add SinkV2 flush rows dashboards #7325

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Oct 11, 2022

What problem does this PR solve?

Issue Number: ref #5928

What is changed and how it works?

add SinkV2 flush rows dashboards.
image

I also reorder the dashboards and move the SinkV1 dashboard below.

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 11, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • zhaoxinyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 11, 2022
@Rustin170506 Rustin170506 added component/metrics-logging Metrics and logging component. area/ticdc Issues or PRs related to TiCDC. labels Oct 11, 2022
@Rustin170506 Rustin170506 requested review from asddongmen, hicqu and zhaoxinyu and removed request for hicqu October 11, 2022 07:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #7325 (ebcb0be) into master (2843d67) will increase coverage by 0.1748%.
The diff coverage is 58.8905%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.6802% <63.8571%> (+0.4605%) ⬆️
dm 51.9477% <36.6666%> (+0.0426%) ⬆️
engine 60.8435% <54.0955%> (-0.2140%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7325        +/-   ##
================================================
+ Coverage   59.6477%   59.8226%   +0.1748%     
================================================
  Files           790        798         +8     
  Lines         91016      91228       +212     
================================================
+ Hits          54289      54575       +286     
+ Misses        31982      31889        -93     
- Partials       4745       4764        +19     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2022
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ebcb0be

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2022
@ti-chi-bot
Copy link
Member

@hi-rustin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 3752703 into pingcap:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/metrics-logging Metrics and logging component. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants