-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine(externalresource): configure storage only on master #7390
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
bffbdbf
to
d42dccc
Compare
chaos test verified in :https://github.com/CharlesCheung96/tiflow/actions/runs/3270307081 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
4f97acb
to
6918c7f
Compare
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6918c7f
|
@CharlesCheung96: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-verify |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #7390 +/- ##
================================================
+ Coverage 59.7990% 59.8537% +0.0546%
================================================
Files 801 803 +2
Lines 91968 92148 +180
================================================
+ Hits 54996 55154 +158
- Misses 32180 32199 +19
- Partials 4792 4795 +3 |
What problem does this PR solve?
Issue Number: ref #7304
What is changed and how it works?
broker.OpenStorage
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note