Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine(externalresource): configure storage only on master #7390

Merged
merged 7 commits into from
Oct 18, 2022

Conversation

CharlesCheung96
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #7304

What is changed and how it works?

  1. configure storage only on master
  2. fix some teses in gcrunner
  3. add opts for broker.OpenStorage

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 17, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/engine Issues or PRs related to Dataflow Engine. labels Oct 17, 2022
@CharlesCheung96
Copy link
Contributor Author

engine/pkg/externalresource/broker/interfaces.go Outdated Show resolved Hide resolved
engine/proto/master.proto Outdated Show resolved Hide resolved
@amyangfei amyangfei added the status/ptal Could you please take a look? label Oct 18, 2022
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

engine/executor/dm/worker.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 18, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6918c7f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 18, 2022
@ti-chi-bot
Copy link
Member

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/run-verify

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Merging #7390 (0693b69) into master (84ef430) will increase coverage by 0.0546%.
The diff coverage is 66.6666%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.6150% <76.9230%> (+0.1204%) ⬆️
dm 52.0143% <100.0000%> (+0.0431%) ⬆️
engine 60.6944% <18.7500%> (-0.1593%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7390        +/-   ##
================================================
+ Coverage   59.7990%   59.8537%   +0.0546%     
================================================
  Files           801        803         +2     
  Lines         91968      92148       +180     
================================================
+ Hits          54996      55154       +158     
- Misses        32180      32199        +19     
- Partials       4792       4795         +3     

@ti-chi-bot ti-chi-bot merged commit b422641 into pingcap:master Oct 18, 2022
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issues or PRs related to Dataflow Engine. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants