Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumer/(ticdc): Add a consumer for cloud storage sink #7481

Merged
merged 13 commits into from
Nov 3, 2022

Conversation

zhaoxinyu
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #6797

What is changed and how it works?

Add a cloud storage sink consumer. The consumer will periodically pulls data from external storage system and translate to row changed event which can be digested by the downstream system.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 28, 2022
@zhaoxinyu
Copy link
Contributor Author

/cc @asddongmen
/cc @3AceShowHand

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #7481 (9917eb1) into master (c0c9a43) will decrease coverage by 5.4553%.
The diff coverage is 72.9591%.

Additional details and impacted files
Flag Coverage Δ
cdc ?
dm 52.0605% <73.3871%> (+0.0448%) ⬆️
engine 61.3007% <72.2222%> (+0.2733%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7481        +/-   ##
================================================
- Coverage   59.8343%   54.3790%   -5.4554%     
================================================
  Files           804        424       -380     
  Lines         92365      53254     -39111     
================================================
- Hits          55266      28959     -26307     
+ Misses        32287      21534     -10753     
+ Partials       4812       2761      -2051     

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 3, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 3, 2022
@zhaoxinyu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@zhaoxinyu: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@asddongmen
Copy link
Contributor

/merge

@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3dbf3ff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 3, 2022
@zhaoxinyu
Copy link
Contributor Author

/run-verify

@zhaoxinyu
Copy link
Contributor Author

/run-all-tests

@zhaoxinyu
Copy link
Contributor Author

/run-kafka-integration-test
/run-verify

@ti-chi-bot ti-chi-bot merged commit 13c2fb9 into pingcap:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants