Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifier(engine): fix Flush deadloop in closed notifier #7509

Merged
merged 9 commits into from
Nov 2, 2022
Merged

notifier(engine): fix Flush deadloop in closed notifier #7509

merged 9 commits into from
Nov 2, 2022

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #7506

What is changed and how it works?

  • Flush should return immediately if notifier has been closed.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@amyangfei amyangfei added the area/engine Issues or PRs related to Dataflow Engine. label Nov 1, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 1, 2022
@amyangfei amyangfei marked this pull request as ready for review November 1, 2022 08:35
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 1, 2022
@amyangfei
Copy link
Contributor Author

/run-engine-integration-test

sleepymole
sleepymole reviewed Nov 1, 2022
View reviewed changes
engine/servermaster/executor_manager.go Outdated
}()

return nil
}
}

// Stop implements ExecutorManager.Stop
func (e *ExecutorManagerImpl) Stop() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this method and inline e.notifier.Close() to Run method.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022 •
edited
Loading

Codecov Report

Merging #7509 (a4d264d) into master (6b48846) will decrease coverage by 6.0398%.
The diff coverage is 62.0950%.

❗ Current head a4d264d differs from pull request most recent head 3bfee60. Consider uploading reports for the commit 3bfee60 to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 67.4351% <58.7403%> (-0.2027%) ⬇️
dm 52.0562% <86.8421%> (?)
engine 61.3007% <72.2222%> (+0.1169%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7509        +/-   ##
================================================
- Coverage   65.9877%   59.9479%   -6.0399%     
================================================
  Files           564        811       +247     
  Lines         52337      92909     +40572     
================================================
+ Hits          34536      55697     +21161     
- Misses        15129      32375     +17246     
- Partials       2672       4837      +2165

@amyangfei
Copy link
Contributor Author

run-engine-integration-test

@amyangfei
Copy link
Contributor Author

/run-engine-integration-test

@amyangfei amyangfei added the status/ptal Could you please take a look? label Nov 1, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2022
@amyangfei
Copy link
Contributor Author

/run-engine-integration-test

@amyangfei
Copy link
Contributor Author

/run-engine-integration-test

@amyangfei
Copy link
Contributor Author

/run-engine-integration-test

2 similar comments
@amyangfei
Copy link
Contributor Author

/run-engine-integration-test

@amyangfei
Copy link
Contributor Author

/run-engine-integration-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2022
@amyangfei
Copy link
Contributor Author

/run-engine-integration-test

@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c2302c3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2022
@ti-chi-bot
Copy link
Member

@amyangfei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit de6ea32 into pingcap:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@sleepymole sleepymole sleepymole approved these changes

Assignees
No one assigned
Labels
area/engine Issues or PRs related to Dataflow Engine. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

server master leader gets stuck
5 participants
@amyangfei @ti-chi-bot @codecov-commenter @sleepymole @CharlesCheung96