Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precheck(dm): refine error message & instruction #7696

Merged
merged 9 commits into from
Nov 29, 2022

Conversation

buchuitoudegou
Copy link
Contributor

@buchuitoudegou buchuitoudegou commented Nov 23, 2022

What problem does this PR solve?

Issue Number: close #7621

What is changed and how it works?

  • refine error message and instruction
  • merge instruction for each table in table compatibility check

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 23, 2022
@buchuitoudegou
Copy link
Contributor Author

/area dm
/run-dm-integration-test

the message and instruction need to be confirmed by Frank

@ti-chi-bot ti-chi-bot added the area/dm Issues or PRs related to DM. label Nov 23, 2022
@buchuitoudegou
Copy link
Contributor Author

/run-dm-integration-test

@buchuitoudegou
Copy link
Contributor Author

/cc @okJiang

@buchuitoudegou
Copy link
Contributor Author

/cc @D3Hunter PTAL

@ti-chi-bot
Copy link
Member

@buchuitoudegou: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @D3Hunter PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #7696 (658fafc) into master (bf9e9ad) will increase coverage by 0.0165%.
The diff coverage is 81.3559%.

Additional details and impacted files
Flag Coverage Δ
cdc 66.3374% <ø> (-0.0100%) ⬇️
dm 52.2171% <81.2500%> (+0.0544%) ⬆️
engine 64.0202% <81.8181%> (-0.0023%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7696        +/-   ##
================================================
+ Coverage   59.9132%   59.9297%   +0.0165%     
================================================
  Files           810        810                
  Lines         93098      93129        +31     
================================================
+ Hits          55778      55812        +34     
+ Misses        32472      32468         -4     
- Partials       4848       4849         +1     

Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

dm/pkg/checker/binlog.go Outdated Show resolved Hide resolved
dm/pkg/checker/binlog.go Outdated Show resolved Hide resolved
dm/pkg/checker/mysql_server.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 28, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2022
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function and text are LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 28, 2022
@buchuitoudegou
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@buchuitoudegou: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@buchuitoudegou
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9e9e7c0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 29, 2022
@buchuitoudegou
Copy link
Contributor Author

/run-verify

@buchuitoudegou
Copy link
Contributor Author

@ti-chi-bot
Copy link
Member

@buchuitoudegou: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 92523b2 into pingcap:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DM: refine error message in precheck
6 participants