lightning(dm): ignore checkpoint error should using ExtStorage

[lance6716]

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: ref #7114

What is changed and how it works?

in old code, (l *LightningLoader) ignoreCheckpointError forget to use engine's injected S3 to cleanup checkpoint

Check List

Tests

• Integration test

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• D3Hunter
• okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[lance6716]

/cc @D3Hunter @okJiang

[lance6716]

but the progress becomes 0% 😂

    "finished_unit_status": {
        "mysql-01": [
 ...
            {
                "Unit": "DMLoadTask",
                "Task": "mysql-01",
                "Stage": "Finished",
                "CfgModRevision": 0,
                "StageUpdatedTime": "2022-11-24T05:20:55.336177527Z",
                "Result": {},
                "Status": {
                    "totalBytes": 614,
                    "progress": "0.00 %"
                },
                "Duration": 48761762780
            }
        ]

[codecov-commenter]

Codecov Report

Merging #7702 (88b0f41) into master (6d24a57) will decrease coverage by 0.0386%.
The diff coverage is 47.6190%.

Additional details and impacted files

Flag	Coverage Δ
engine	64.0047% <ø> (+0.0078%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7702        +/-   ##
================================================
- Coverage   59.9034%   59.8648%   -0.0386%     
================================================
  Files           810        810                
  Lines         93255      93260         +5     
================================================
- Hits          55863      55830        -33     
- Misses        32535      32567        +32     
- Partials       4857       4863         +6     

[lance6716]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 88b0f41

[ti-chi-bot]

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[lance6716]

/run-engine-integration-test