Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mounter: skip the DML of ineligible table #773

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Jul 20, 2020

What problem does this PR solve?

skip the DML of ineligible table

fix the part 2 of #743

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

@zier-one zier-one added status/ptal Could you please take a look? type/bugfix This PR fixes a bug. labels Jul 20, 2020
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2020
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for bugfix.

@zier-one
Copy link
Contributor Author

Please add tests for bugfix.

the test is implemented in UTF cases
https://github.com/pingcap/automated-tests/pull/420/files#diff-3af30509c8adc498f016b4d35f74ab44R90

@overvenus
Copy link
Member

/lgtm

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 22, 2020
@zier-one
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 22, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

Merging #773 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #773   +/-   ##
===========================================
  Coverage   33.5719%   33.5719%           
===========================================
  Files            94         94           
  Lines         10336      10336           
===========================================
  Hits           3470       3470           
  Misses         6530       6530           
  Partials        336        336           

@ti-srebot ti-srebot merged commit 97364a3 into pingcap:master Jul 22, 2020
@zier-one zier-one deleted the fix_743_2 branch September 14, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants