checker(dm): support wildcard in privilege checking #7739
Conversation
Signed-off-by: lance6716 <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
needs-cherry-pick-release-6.1
Signed-off-by: lance6716 <[email protected]>
dm/pkg/checker/privilege.go
Outdated
| } | ||
| if _, ok := dbPrivs.tables[tableName]; !ok { | ||
| continue | ||
| for dbName, dbPrivs := range privs.dbs { |
There was a problem hiding this comment.
https://dev.mysql.com/doc/refman/5.7/en/grant.html
The _ and % wildcards are permitted when specifying database names in GRANT statements that grant privileges at the database level (GRANT ... ON db_name.*).
When a database name is not used to grant privileges at the database level, but as a qualifier for granting privileges to some other object such as a table or routine (for example, GRANT ... ON db_name.tbl_name), MySQL interprets wildcard characters as literal characters.
wildcard cannot be used on table level grant, not need to change here
Signed-off-by: lance6716 <[email protected]>
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 8dc362c
|
ti-chi-bot
added
the
status/can-merge
|
@lance6716: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
In response to a cherrypick label: new pull request created: #7752. |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: lance6716 [email protected]
What problem does this PR solve?
Issue Number: close #7645
What is changed and how it works?
use the same function of TiDB privilege checking
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note