Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/security(ticdc): support online load tls config #7927

Merged
merged 1 commit into from
Dec 20, 2022
Merged

pkg/security(ticdc): support online load tls config #7927

merged 1 commit into from
Dec 20, 2022

Conversation

CharlesCheung96
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #7908

What is changed and how it works?

  1. use GetClientCertificate and GetCertificate in tls.config

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`support online load tls config in TiCDC`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Dec 16, 2022
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2022
@CharlesCheung96 CharlesCheung96 force-pushed the support_online_reload_tls branch 2 times, most recently from d080467 to 7e5bddc Compare December 19, 2022 10:10
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review December 19, 2022 10:10
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

CharlesCheung96 added a commit to CharlesCheung96/tiflow that referenced this pull request Dec 20, 2022
@CharlesCheung96
pkg/security(ticdc): support online load tls config (pingcap#7927)
3266836 
close pingcap#7908
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-engine-integration-test

@3AceShowHand
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2ba7b4c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2022
@ti-chi-bot ti-chi-bot merged commit ee7f68f into pingcap:master Dec 20, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 20, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7942.

ti-chi-bot pushed a commit that referenced this pull request Dec 20, 2022
@CharlesCheung96
pkg/security(ticdc): support online load tls config (#7927) (#7938)
f3e8a76 
close #7908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@amyangfei amyangfei amyangfei approved these changes

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support online reload tls in ticdc
4 participants
@CharlesCheung96 @ti-chi-bot @3AceShowHand @amyangfei