owner: includes stopped changefeed when calculating gc safepoint #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
type/bugfix
amyangfei
force-pushed
the
gc-safepoint-for-failed-feeds
branch
from
1948dd8
to
2466328
Compare
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
===========================================
Coverage 32.4428% 32.4428%
===========================================
Files 97 97
Lines 10631 10631
===========================================
Hits 3449 3449
Misses 6846 6846
Partials 336 336 |
|
/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0 |
amyangfei
added
the
release-blocker
zier-one
approved these changes
Aug 3, 2020
|
/lgtm |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Aug 3, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/merged |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix bug found in https://github.com/pingcap/ticdc/issues/791 & https://github.com/pingcap/ticdc/issues/810
What is changed and how it works?
stoppedFeedsfields in ownerCheck List
Tests
Release note