Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mounter: support to output pre table info in ddl events #799

Merged
merged 7 commits into from
Aug 3, 2020

Conversation

zier-one
Copy link
Contributor

What problem does this PR solve?

support to output pre table info in ddl events

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

@zier-one zier-one added the status/ptal Could you please take a look? label Jul 28, 2020
@zier-one
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei added this to the v4.0.5 milestone Aug 3, 2020
@amyangfei amyangfei added the release-blocker This issue blocks a release. Please solve it ASAP. label Aug 3, 2020
cdc/entry/schema_storage.go Outdated Show resolved Hide resolved
cdc/model/schema_storage.go Outdated Show resolved Hide resolved
@zier-one
Copy link
Contributor Author

zier-one commented Aug 3, 2020

@liuzix @amyangfei PTAL again

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2020
@liuzix
Copy link
Contributor

liuzix commented Aug 3, 2020

/lgtm

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 3, 2020
@zier-one
Copy link
Contributor Author

zier-one commented Aug 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 808

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 9f55889 into pingcap:master Aug 3, 2020
@zier-one zier-one deleted the pre_table_info branch September 14, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants