cdc: add changefeed epoch to prevent unexpected state #8268
Conversation
Signed-off-by: Neil Shen <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
needs-cherry-pick-release-5.0
|
/run-all-tests |
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
|
/run-all-tests |
Signed-off-by: Neil Shen <[email protected]>
|
/run-all-tests |
| @@ -146,6 +146,8 @@ type ChangeFeedInfo struct { | |||
| Error *RunningError `json:"error"` | |||
|
|
|||
| CreatorVersion string `json:"creator-version"` | |||
| // Epoch is the epoch of a changefeed, changes on every restart. | |||
There was a problem hiding this comment.
how about refine this comment, what an epoch stand for ?
There was a problem hiding this comment.
Is epoch similar to term?
cdc/owner/changefeed.go
Outdated
| @@ -583,6 +584,7 @@ LOOP: | |||
| c.initialized = true | |||
| log.Info("changefeed initialized", | |||
| zap.String("namespace", c.state.ID.Namespace), | |||
| zap.Uint64("changefeedEpoch", epoch), | |||
There was a problem hiding this comment.
reorder the fields, changefeed first, and rename this to epoch should be ok.
| @@ -370,6 +359,18 @@ func (m *feedStateManager) patchState(feedState model.FeedState) { | |||
| info.AdminJobType = adminJobType | |||
| changed = true | |||
| } | |||
| if updateEpoch { | |||
| previous := info.Epoch | |||
| ctx, cancel := context.WithTimeout(context.TODO(), 5*time.Second) | |||
There was a problem hiding this comment.
Is context.TODO() ok here ?
There was a problem hiding this comment.
Tried, it will change a lot of unrelated code, I'll add a TODO here.
Signed-off-by: Neil Shen <[email protected]>
|
/run-all-tests |
|
/run-all-tests |
|
/run-verify |
|
@overvenus: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
close pingcap#7657 Signed-off-by: Neil Shen <[email protected]>
close #7657 Signed-off-by: Neil Shen <[email protected]>
What problem does this PR solve?
Issue Number: close #7657
Also close #8242
What is changed and how it works?
Add changefeed epoch, so we can distinguish messages after changefeed restart.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note