-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvclient: fix CRTs less than resolvedTs in puller #927
Conversation
/run-integration-tests |
# Conflicts: # cdc/kv/client.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@MyonKeminta,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: tools(slack). |
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
===========================================
Coverage 33.8970% 33.8970%
===========================================
Files 99 99
Lines 12004 12004
===========================================
Hits 4069 4069
Misses 7534 7534
Partials 401 401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
/run-integration-tests |
@leoppro merge failed. |
What problem does this PR solve?
The resolvedTs may be reversed in the following cases:
In steps 6 and 7, the ResolvedTS is regressed from 10 to 5.
What is changed and how it works?
In steps 7, use the checkpointTs record in range lock instead of which in failed message.
Check List
Tests
Release note