api(ticdc): forward changefeed related api to changefeed owner capture #9412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
|
/test all |
| @@ -23,6 +23,7 @@ import ( | |||
| "github.com/pingcap/tiflow/cdc/capture" | |||
| "github.com/pingcap/tiflow/cdc/model" | |||
| "github.com/pingcap/tiflow/pkg/errors" | |||
| cerror "github.com/pingcap/tiflow/pkg/errors" | |||
There was a problem hiding this comment.
duplicate import
Suggested change
| cerror "github.com/pingcap/tiflow/pkg/errors" | |
| cerror "github.com/pingcap/tiflow/pkg/errors" |
| changefeedID := changefeedIDFunc(ctx) | ||
| // check if this capture is the changefeed owner | ||
| if handleRequestIfIsChnagefeedOwner(ctx, p, changefeedID) { | ||
| return | ||
| } | ||
|
|
||
| // forward to the controller to find the changefeed owner capture |
There was a problem hiding this comment.
Whether it is possible to directly forward to the node where the owner resides?
There was a problem hiding this comment.
no, I think only the controller know where is the changefeed owner
| api.ForwardToCapture(ctx, info.ID, changefeedCaptureOwner.AdvertiseAddr) | ||
| ctx.Abort() | ||
| } | ||
| } | ||
|
|
||
| func handleRequestIfIsChnagefeedOwner(ctx *gin.Context, p capture.Capture, changefeedID model.ChangeFeedID) bool { |
There was a problem hiding this comment.
typo in the function name
3AceShowHand
approved these changes
Jul 20, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
asddongmen
approved these changes
Jul 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9411
What is changed and how it works?
forward changefeed related api to changefeed owner capture
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note